Open
Conversation
|
FYI This PR doesn't seem to work for the |
porsager
force-pushed
the
master
branch
2 times, most recently
from
4fd011e to
a92f470
Compare
porsager
force-pushed
the
master
branch
2 times, most recently
from
4a0fe34 to
3a43815
Compare
stephenh
force-pushed
the
add-onquery-callback
branch
from
d8d2daf to
a25d159
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on @porsager 's
query-statsbranch with @abustany 's fixes (to manage the 2nd/3rdonqueryinstances on thequery-level instead of globalhandlerlevel iirc).Disclaimers that:
onqueryaccepts the Query instance as-is, which can be difficult for APM tools to look at "just give me the SQL string + params", so it might be worth passing in an API that is higher-level/easier-to-consume than the raw QueryFixes #461.